-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS headers are no longer included on results.json responses #382
Comments
Previous work related to this as a reference: getredash#1374 @rafrombrc Currently re:Dash code requires the requesting website to send an "Origin" header. If I modify the request headers using this Firefox Add-On https://addons.mozilla.org/en-US/firefox/addon/modify-header-value/ to send the "Origin" header then I get the "Access-Control-Allow-Origin" response header on my local. Do we want to remove the requirement that the requesting website has to send an "Origin" header? |
So this issue actually appears to be down to the result set being too large, postgres is reporting ~384MB, did something change in the query or the underlying data set? |
It makes sense that the dataset grew over time. I'm a bit surprised by the amount though. It would be nice if there was a more direct error. |
Captured that CORS headers should be captured in 500 errors here: #416 |
Issue Summary
CORS headers are no longer sent on responses for
results.json
. This prevents Redash data from being used in some kinds of external dashboards. I'm seeing this in Firefox Nightly on Linux, but I expect it would happen in any browser.Steps to Reproduce
Previously (about 3 weeks ago), the CORS headers were included, allowing external dashboards like this to work.
The query I'm trying to read data from is https://sql.telemetry.mozilla.org/queries/52031.
Technical details:
The text was updated successfully, but these errors were encountered: