Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motivation for asking to use a modified version of the viewer #8513

Closed
stijnherreman opened this issue Jun 12, 2017 · 1 comment
Closed

Motivation for asking to use a modified version of the viewer #8513

stijnherreman opened this issue Jun 12, 2017 · 1 comment

Comments

@stijnherreman
Copy link

https://github.com/mozilla/pdf.js/wiki/Setup-pdf.js-in-a-website says:

The viewer is built on the display layer and is the UI for PDF viewer in Firefox and the other browser extensions within the project. It can be a good starting point for building your own viewer. However, we do ask if you plan to embed the viewer in your own site, that it not just be an unmodified version. Please re-skin it or build upon it.

What is the motivation for this? Is it a technical reason? Or are you hoping to encourage people to build more viewers? Please clarify.

@yurydelendik
Copy link
Contributor

What is the motivation for this? Is it a technical reason?

It's multiple reasons. In numerous occasions, people mistakenly called defects in custom deployments as Firefox bugs (since PDF.js demo viewer looks nearly identical to PDF Viewer). Security, see #6916. Also, people are asking for configuration that is not easy to invest in (e.g. skins, adding/removing toolbar buttons, etc.) -- while it is fixable it requires lots of investment in the support.

Or are you hoping to encourage people to build more viewers?

Yes, this too.

Closing as answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants