Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement publishing a release to the pdfjs-dist GitHub repository #18357

Closed
timvandermeij opened this issue Jul 1, 2024 · 7 comments · Fixed by #18434
Closed

Implement publishing a release to the pdfjs-dist GitHub repository #18357

timvandermeij opened this issue Jul 1, 2024 · 7 comments · Fixed by #18434
Assignees
Labels

Comments

@timvandermeij
Copy link
Contributor

In #18350 the release publishing logic got ported from the bots to GitHub Actions, but the long-broken GitHub repository push logic to the pdfjs-dist repository was left out. This issue tracks reimplementing pushing to the pdfjs-dist Git repository as part of the new publish_release.yml workflow.

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Jul 1, 2024

Before doing this I would like to gauge if there is actually interest for this. The last push to https://github.com/mozilla/pdfjs-dist was from January 1st, 2023 and we haven't really had many questions about it, so I'm therefore not sure if just pushing to NPM alone isn't enough? Most other NPM packages also just push artifacts to NPM without also having a separate Git repository, so I'd like to collect the use cases for such a repository first.

@Snuffleupagus
Copy link
Collaborator

Before doing this I would like to gauge if there is actually interest for this.

I'd support deprecating the pdfjs-dist repository, simply because it'd reduce the number of things that we have to support.[1]


[1] If we go down this route then I'd probably suggest that we update, according to my comments, and land mozilla/pdfjs-dist#22 and afterwards we can mark the repository as "archived".

@Snuffleupagus
Copy link
Collaborator

I've just updated and squash-merged mozilla/pdfjs-dist#22, since that seems like the right thing to do in the short term.


Most other NPM packages also just push artifacts to NPM without also having a separate Git repository, so I'd like to collect the use cases for such a repository first.

From my perspective, I do think that we should add a few "restrictions" here:

  • It should be technically impossible to achieve the desired outcome without the Git repository, rather than only "I prefer to not use NPM".
  • There should be a number of different users and use-cases affected, since maintaining this for e.g. a single user doesn't seem feasible.

@Snuffleupagus
Copy link
Collaborator

I think that we should just move forward with "archiving" the pdfjs-dist repository (and perhaps also clean-up the gulpfile).

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jul 13, 2024

Additionally, I believe from looking at old issues that a significant reason for creating the pdfjs-dist repository was to support Bower since otherwise there wouldn't have been builds to "point to" in the Bower registry.
However, note that we stopped supporting Bower almost two years ago, see PR #15390, since already by that point it'd been deprecated for a number of years.

@timvandermeij
Copy link
Contributor Author

@calixteman Could you archive the https://github.com/mozilla/pdfjs-dist repository? There should be a red "Archive this repository" button at the bottom of https://github.com/mozilla/pdfjs-dist/settings.

@calixteman
Copy link
Contributor

@calixteman Could you archive the https://github.com/mozilla/pdfjs-dist repository? There should be a red "Archive this repository" button at the bottom of https://github.com/mozilla/pdfjs-dist/settings.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants