-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement publishing a release to the pdfjs-dist
GitHub repository
#18357
Comments
Before doing this I would like to gauge if there is actually interest for this. The last push to https://github.com/mozilla/pdfjs-dist was from January 1st, 2023 and we haven't really had many questions about it, so I'm therefore not sure if just pushing to NPM alone isn't enough? Most other NPM packages also just push artifacts to NPM without also having a separate Git repository, so I'd like to collect the use cases for such a repository first. |
I'd support deprecating the [1] If we go down this route then I'd probably suggest that we update, according to my comments, and land mozilla/pdfjs-dist#22 and afterwards we can mark the repository as "archived". |
I've just updated and squash-merged mozilla/pdfjs-dist#22, since that seems like the right thing to do in the short term.
From my perspective, I do think that we should add a few "restrictions" here:
|
I think that we should just move forward with "archiving" the |
Additionally, I believe from looking at old issues that a significant reason for creating the |
@calixteman Could you archive the https://github.com/mozilla/pdfjs-dist repository? There should be a red "Archive this repository" button at the bottom of https://github.com/mozilla/pdfjs-dist/settings. |
Done |
In #18350 the release publishing logic got ported from the bots to GitHub Actions, but the long-broken GitHub repository push logic to the pdfjs-dist repository was left out. This issue tracks reimplementing pushing to the
pdfjs-dist
Git repository as part of the new publish_release.yml workflow.The text was updated successfully, but these errors were encountered: