This repository has been archived by the owner on Jan 23, 2018. It is now read-only.
silence logging from components while running tests #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,5 +3,11 @@ | |||
| // See: https://github.com/webpack/karma-webpack#alternative-usage | |||
| import 'babel-core/polyfill'; | |||
|
|
|||
| // silence logging in components | |||
| var logLevels = ['log', 'warn', 'info', 'error']; | |||
There was a problem hiding this comment.
What about debug? It obviously doesn't get used but adding it would be future-proof.
|
That is sooooo much easier to look at, thank you! 👍 I have a question about Let me know what you think--feel free to either add |
|
Adding debug is a good idea. I'll also add the trailing comma since consistency is major important, even if this is small. Happy to help out! |
|
Thanks for the quick reply 😄 I combined the commits into one just to make things nice and atomic. Merged in 7f210dd. Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, this closes #463.
I tried using mocha & karma config options to silence all of the logging coming from the client code, but nothing I tried worked. I finally decided to just redefine console.log while tests are running. The test output is a lot cleaner now.