Setup instructions for development lead to error

[gpoole]

Following the instructions currently in the README under "Running Locally" leads to an error when trying to install the extension. The following error is seen after following both methods (about:debugging and web-ext):

There was an error during the temporary add-on installation.
Error details

Extension is invalid

Loading locale file _locales/.github/messages.json: Error: Error while loading 'file:///path/to/multi-account-containers/src/_locales/.github/messages.json' (NS_ERROR_FILE_NOT_FOUND)

Removing _locales/.github fixes the problem.

[D-side]

Just encountered the same problem, came up with the same solution.
Was helpful to know it's a valid option since I didn't exactly know what I was doing 🙂

There doesn't seem to be an easy way out of this one:

• GitHub Actions, which the locale submodule relies on, is configured through .github folder at the root of the repository
• Moving the locales into the subfolder of the module is not an option because (1) there's no way to specify an arbitrary directory with locales, (2) there's no way to use a subfolder of a repository as a submodule
• I'm not considering symlinks due to limited platform compatibility

That said, I can think of a couple solutions:

• Making Firefox ignore folder names in _locales of an extension that don't look like language codes
• Deleting src/_locales/.github as part of the setup instructions, it feels kinda dumb to me, but probably the easiest 🙃