Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement 'data missing' background image as an svg path #284

Closed
almossawi opened this issue Dec 19, 2014 · 6 comments
Closed

Reimplement 'data missing' background image as an svg path #284

almossawi opened this issue Dec 19, 2014 · 6 comments
Assignees
Milestone

Comments

@almossawi
Copy link
Contributor

No description provided.

@almossawi almossawi added this to the v2.0 milestone Dec 19, 2014
@almossawi almossawi assigned almossawi and hamilton and unassigned almossawi Dec 20, 2014
@almossawi almossawi modified the milestones: v2.1, v2.0 Dec 23, 2014
@hamilton
Copy link
Collaborator

excellent! This will be fun ~

@almossawi
Copy link
Contributor Author

I wasn't sure whether you'd be available today, so I moved it to v2.1 :) I'll start updating the documentation in a bit.

@hamilton
Copy link
Collaborator

Yeah I think that's wise - I have limited time in front of a computer over the next few days unfortunately

@almossawi
Copy link
Contributor Author

@hamilton A second pair of eyes would be good. Let me know your thoughts.

Missing charts are configurable and vary slightly from one chart to another. We're using the same css rules as our lines and areas, so we don't need to do anything extra for the dark theme.

@almossawi almossawi assigned almossawi and unassigned hamilton Jan 21, 2015
@hamilton
Copy link
Collaborator

Looks pretty good - thanks for taking that on. I might make a few small changes tomorrow, in particular adding margins to the missing chart type so they visually cohere a little more with non-missing charts

@almossawi
Copy link
Contributor Author

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants