-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement 'data missing' background image as an svg path #284
Comments
excellent! This will be fun ~ |
I wasn't sure whether you'd be available today, so I moved it to v2.1 :) I'll start updating the documentation in a bit. |
Yeah I think that's wise - I have limited time in front of a computer over the next few days unfortunately |
@hamilton A second pair of eyes would be good. Let me know your thoughts. Missing charts are configurable and vary slightly from one chart to another. We're using the same css rules as our lines and areas, so we don't need to do anything extra for the dark theme. |
Looks pretty good - thanks for taking that on. I might make a few small changes tomorrow, in particular adding margins to the missing chart type so they visually cohere a little more with non-missing charts |
Sounds good 👍 |
No description provided.
The text was updated successfully, but these errors were encountered: