Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-detect and set target_locale for langpacks #8802

Closed
eviljeff opened this issue Jun 13, 2022 · 2 comments · Fixed by mozilla/addons-server#19360
Closed

auto-detect and set target_locale for langpacks #8802

eviljeff opened this issue Jun 13, 2022 · 2 comments · Fixed by mozilla/addons-server#19360
Assignees
Labels
Milestone

Comments

@eviljeff
Copy link
Member

Follow-up from #7908 - we detect the target_locale for dictionaries but not langpacks. We should do something similar for langpacks

@ioanarusiczki
Copy link

ioanarusiczki commented Jun 17, 2022

@eviljeff
I submitted lang packs with dev hub and the new API (PUT or POST) and checked that at creation of a new lang pack the target_locale is present in admin -> this is happening now
The field from admin can be edited by the admin.

I tried to make a new version upload for an older lang pack -> the field remains empty -> it is populated with the locale from the langpack_id (inside manifest.json) only when a new locale is created.
Also, when I change the langpack_id and submit a new version -> nothing changes (the target locale from create is displayed)

I think this should be ok, but if not , let me know.

@eviljeff
Copy link
Member Author

Also, when I change the langpack_id and submit a new version -> nothing changes (the target locale from create is displayed)

We should probably error for that, but langpacks are only submitable by releng anyway, so there's no much risk of accidents.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants