Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codestyle and docs jobs in travis #6405

Closed
eviljeff opened this issue Feb 12, 2019 · 2 comments · Fixed by mozilla/addons-server#10683
Closed

Fix codestyle and docs jobs in travis #6405

eviljeff opened this issue Feb 12, 2019 · 2 comments · Fixed by mozilla/addons-server#10683
Assignees
Labels
qa:not_needed repository:addons-server Issue relating to addons-server
Milestone

Comments

@eviljeff
Copy link
Member

After mozilla/addons-server#10592 the codestyle job isn't actually doing a flake8 check because the make invocation is missing the -f to specify the correct Makefile. (It didn't need one before because the recipe was in the primary Makefile before, and now it's in Makefile-docker).
Also the docs job is broken (for an unknown period of time) for the opposite reason - the recipe is in Makefile, not Makefile-docker.

We should fix the things. Bonus for simplifying and making it so we don't have to do make -f ... everywhere in tox.ini

@diox diox self-assigned this Feb 12, 2019
@diox diox modified the milestones: 2019.02.14, 2019.02.21 Feb 12, 2019
@EnTeQuAk
Copy link
Contributor

oh man, don't trust successful outputs 👀

@AlexandraMoga
Copy link

Please add STR or the label qa:not needed.
Thanks

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants