Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(listed-only) Addon reviewers don't see the "approval_notes" via addons api #1897

Open
ioanarusiczki opened this issue Aug 23, 2022 · 2 comments
Labels
component:api repository:addons-server Issue relating to addons-server

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Aug 23, 2022

Followup #8835

STR:

  1. As a reviewer with permissions (can review listed addons) make a request such as
    https://addons-dev.allizom.org/api/v5/addons/addon/622084/versions/1694723/ -> listed version, not public
    https://addons-dev.allizom.org/api/v5/addons/addon/622084/versions/1694724/ -> public listed version

Expected result:
"approval_notes" should be displayed in the JSON response.

Notes:
This is not reproducible for the unlisted reviewers.

┆Issue is synchronized with this Jira Task

@eviljeff
Copy link
Member

listed reviewers are a bit of an edge case. For unlisted reviewers (and other admin-ish users) we can use the developer's serializer; for listed reviewers we can't. I'm not sure there is much of a use-case here as there are dedicated reviewer apis for code-manager etc, so it's unclear under what circumstances a listed reviewer would need such information via the general addons api.

@eviljeff eviljeff changed the title Addon reviewers don't see the "approval_notes" (listed-only) Addon reviewers don't see the "approval_notes" via addons api Sep 8, 2022
@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

5 participants