[Bug]: Appeals forwarded to Legal don't seem to be working

[ioanarusiczki]

What happened?

From #15255 (comment)

1. add-on is reported for violating add-on policies, flagged for HR and content is disabled
2. Developer sends the appeal and version gets to the manual review queue being flagged again for HR
3. The appeal is sent to Legal Escalations queue

What did you expect to happen?

Cinder Legal Escalations job is https://stage.cinder.nonprod.webservices.mozgcp.net/job/6c3485f3-219a-4933-98f4-5a119456e567

In rev tools the version still flagged for HR https://reviewers.addons.allizom.org/en-US/reviewers/review/2244538

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[eviljeff]

@ioanarusiczki can you expand on "doesn't seem to be working" - the notes include a link to a job on cinder, indicating the forward action itself did work. Is it actions taken in cinder don't then work (like #15278)? Or that the appeal NHR flag is not cleared as expected?

[ioanarusiczki]

Looks like an appeal has the same layout as an abuse report https://stage.cinder.nonprod.webservices.mozgcp.net/job/27d115cb-7fdb-40ac-9ecd-e64f74060afc

An appeal from any other queue would look like https://stage.cinder.nonprod.webservices.mozgcp.net/job/0fad1844-ffee-4564-a654-e1417eeb977b -> it's "Appealed" with Appeal Decision on the right.

In the Legal queue you can't make a difference between an abuse report or appeal -> I think this would be one problem
The other is indeed, that NHR is not removed in rev tools. ❓

The good news is that if I tried to moderate a developer appeal from Legal Escalations queue it worked:

• I could deny a developer's appeal and keep content disabled with Illegal content policy ✅

email sent ✅

• I could approve an appeal and reinstate content with Ignore policy ✅
  email sent ✅
  

• I could escalate the appeal to AMO ✅

But in all the above situations the nhr in rev tools is still applied. ❌