Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Human review action should be recorded instead of auto-approval #15276

Open
1 task done
ioanarusiczki opened this issue Jan 10, 2025 · 1 comment
Open
1 task done

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Jan 10, 2025

What happened?

Followup for #15174 (comment)

  1. There's a version that goes to the manual review queue which is flagged for HR but automatically approved
    https://reviewers.addons.allizom.org/en-US/reviewers/review/2244534
  2. Going in admin to review queue history displays in the entry that it's been "approved"

What did you expect to happen?

Confirm approval should be the action displayed.

Note: the exit_date is correct -> belongs to confirm approval action

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@diox
Copy link
Member

diox commented Jan 10, 2025

(This is about reviewqueuehistory)

ReviewQueueHistory.review_decision_log is set to the first activity resulted from reviewer tools action, which is why it's recording the approval here. But we should only do that for human ones, not automated ones: that version would stay in the queue until a human reviewer confirms the approval or makes another action, and that's when we should record.

The solution should simply be to avoid doing anything in ReviewBase.update_queue_history() when self.human_review is False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants