Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests did not catch breaking change from dependency update. #11553

Closed
b4handjr opened this issue Mar 19, 2018 · 3 comments
Closed

Unit tests did not catch breaking change from dependency update. #11553

b4handjr opened this issue Mar 19, 2018 · 3 comments
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@b4handjr
Copy link

b4handjr commented Mar 19, 2018

A breaking change was introduced here but it seems the unit tests run on travisci did not catch the build failure. The integration-tests run on circleci for both addons-frontend and addons-server have been failing due to this update.

We should investigate why the unit tests did not catch the build failure. A PR to pin the version to a known working version has been submitted.

@kumar303
Copy link
Contributor

It was a webpack failure, see #11544

The unit tests should definitely catch this. I haven't looked into why they didn't but since we did not get a failing greenkeeper PR for the postcss-loader update, I suspect they didn't catch it.

@willdurand
Copy link
Member

The unit tests should definitely catch this. I haven't looked into why they didn't but since we did not get a failing greenkeeper PR for the postcss-loader update, I suspect they didn't catch it.

We did not get any Greenkeeper PR actually, I think that's the main reason. Otherwise, we would have caught this error, especially given the error logged in #11544.

@willdurand
Copy link
Member

Based on this PR/branch: mozilla/addons-frontend#5884, which is all green, I pushed a new commit on top of it, with an invalid webpack config in the postcss-loader options: mozilla/addons-frontend@ccde17e.

The build fails as expected: https://travis-ci.org/mozilla/addons-frontend/builds/414016918

I don't think there is an issue with Travis CI not catching an issue in the build process. I think the issue is that we did not get a PR on time from Greenkeeper. I believe that this is a wontfix and we should spend time on #10714.

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

4 participants