You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A breaking change was introduced here but it seems the unit tests run on travisci did not catch the build failure. The integration-tests run on circleci for both addons-frontend and addons-server have been failing due to this update.
We should investigate why the unit tests did not catch the build failure. A PR to pin the version to a known working version has been submitted.
The text was updated successfully, but these errors were encountered:
The unit tests should definitely catch this. I haven't looked into why they didn't but since we did not get a failing greenkeeper PR for the postcss-loader update, I suspect they didn't catch it.
The unit tests should definitely catch this. I haven't looked into why they didn't but since we did not get a failing greenkeeper PR for the postcss-loader update, I suspect they didn't catch it.
We did not get any Greenkeeper PR actually, I think that's the main reason. Otherwise, we would have caught this error, especially given the error logged in #11544.
I don't think there is an issue with Travis CI not catching an issue in the build process. I think the issue is that we did not get a PR on time from Greenkeeper. I believe that this is a wontfix and we should spend time on #10714.
A breaking change was introduced here but it seems the unit tests run on travisci did not catch the build failure. The integration-tests run on circleci for both addons-frontend and addons-server have been failing due to this update.
We should investigate why the unit tests did not catch the build failure. A PR to pin the version to a known working version has been submitted.
The text was updated successfully, but these errors were encountered: