-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot export theme, extension does not work #971
Comments
Thanks for filing, @seampm2001. We should have better documentation for this. If you export the theme, you'll need to sign it on addons.mozilla.org in order to install it successfully. Here are some quick steps:
|
Oh, sorry @seanpm2001, I did not read your issue closely enough! 😅 Can you check your computer system's timestamp? Usually add-ons fail to install because the system clock is out of sync. If that's not the case, we can investigate some other culprits. |
It does really sound like the theme package wasn't signed. Add-ons can only be installed once signed. Caitlin's instructions above should help with that. @seanpm2001 Could you clarify: Are you asking about the inability to export the theme, or the inability to install / import it again? FYI: It's a currently known limitation that SVG files cannot be loaded via Firefox Color. If there is evidence that this is a significant issue, then we can consider bumping the priority of https://bugzilla.mozilla.org/show_bug.cgi?id=1491790 |
@Rob--W The theme zip file contains a blank SVG file, i assume these are the theme graphics. To clarify, I have an inability to export the theme. I have tested the extension in multiple Firefox profiles, and I have the same issue. The theme comes up as corrupt when I try to load it. @caitmuenster I can't get a timestamp for this, as I don't know how to get a time stamp for Firefox. It installed correctly, as everything in the extension works except for the export function. I have noted that some of the top critical reviews on addons.mozilla.org mention the same exact issue, and I am encountering it as well. I decided to open it here, as no-one else seems to have yet. I want to make sure this extension works for everyone who needs it. |
Can we have a pinned notice on this repository to let people know the correct process, or add the process in the README so other people know what to do. I haven't tested the signing method yet, as I don't know where to sign the file. |
If you have a zip file, then the export has succeeded. To test temporarily, visit about: debugging and load the file. Does that work temporarily? To get it signed, see https://extensionworkshop.com/documentation/publish/signing-and-distribution-overview/ |
Absolutely. I might not be able to get to it this week, but it's on my list. :) |
A little bit late, but I went to about:debugging and was able to temporarily load the theme. It is functional, we just need documentation to let people know to do this, or give off some other warning instead of just saying the theme is corrupt. |
I have opened some pull requests to make it easier to understand how the package can be used by those unfamiliar with extension development. |
Cannot export theme
This has been a common issue I have noted by looking at reviews from the past 7 months. I went to install this extension today, and I found that every time I exported the file, it said that it couldn't install the extension, as the extension was corrupt. I can confirm it is, as there is a <600 byte blank SVG file, and a normal JSON file. I am surprised that this isn't being reported as much as it should. I looked through issues before reporting, but couldn't find any recent ones mentioning this, so I will say it here. This may be a duplicate, as this apparently has been an issue for 7 months or more.
I tried to include a screenshot, but the error message goes away before my system can get a screenshot (using F10: PRT SC/Print Screen)
Device specs
Browser version: Firefox Browser 87.0 for Ubuntu Linux 20.04.1
Operating system: Ubuntu Linux 20.04.1
DE: GNOME 3.36.1
The text was updated successfully, but these errors were encountered: