Preserve ESLint default include when just exclude set (#344)

Previously if `exclude` was set manually, it would prevent the default value for `include` being used. Now consumers of the middleware can pass just `exclude` and not have to pass both. See: #315 (comment) The default include in neutrino-preset-airbnb-base has also been removed, since it just duplicated that in neutrino-middleware-eslint.
neutrinojs · Oct 6, 2017 · bb190c4 · bb190c4
1 parent dec7201
commit bb190c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/neutrino-middleware-eslint/index.js b/packages/neutrino-middleware-eslint/index.js
@@ -29,7 +29,7 @@ module.exports = (neutrino, opts = {}) => {
   const failBuild = process.env.NODE_ENV !== 'development' || neutrino.options.command !== 'start';
   const options = merge.all([
     opts,
-    !opts.include && !opts.exclude ? { include: [neutrino.options.source] } : {}
+    !opts.include ? { include: [neutrino.options.source] } : {}
   ]);
 
   neutrino.config

diff --git a/packages/neutrino-preset-airbnb-base/index.js b/packages/neutrino-preset-airbnb-base/index.js
@@ -20,7 +20,6 @@ module.exports = (neutrino, opts = {}) => {
         }
       }
     },
-    opts,
-    !opts.include && !opts.exclude ? { include: [neutrino.options.source] } : {}
+    opts
   ]));
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,6 @@ module.exports = (neutrino, opts = {}) => { @@
             }
           }
         },
-        opts,
-        !opts.include && !opts.exclude ? { include: [neutrino.options.source] } : {}
+        opts
       ]));
     };