fix: project variables #689
#690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarthificial
requested changes
May 17, 2023
packages/core/src/app/Renderer.ts
Outdated
| @@ -80,6 +80,7 @@ export class Renderer { | |||
| resolutionScale: 1, | |||
| timeEventsClass: ReadOnlyTimeEvents, | |||
| }); | |||
| scene.variables.updateSignals(this.project.variables ?? {}); | |||
There was a problem hiding this comment.
I think we should do that in reloadScenes to stay consistent with the Presenter class.
aarthificial
approved these changes
May 18, 2023
|
Thanks for the fix! GitHub will then automatically close the issue upon merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.