-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should Schema Registry client be exported to JS? #55
Comments
I think since the extension is used by dev teams with a lot of different flows and specific needs, it's helpful to have this functionality. It could be an optional setting where users can decide if it is to be implicit or explicit |
I'll probably refactor it to include in the APIs. |
Yes this would be very helpful. I've been in scenarios where I was forced to produce messages without the magic schemaID prefix but which schema lived in the schema registry. Weird, I know. If the schema registry client was exposed, I could use it directly to grab the schema I need, then given the possible refactoring mentioned in issue 50, I could use a plain |
It could be in line with #50. In my opinion, explicit is better than implicit, and it makes things easier for the user, too. Yet, the script becomes bigger and needs more initialization, and I suspect it might be less performant, but it must be tested. These are related:
Update:
I am working on this issue in this branch along with #50, #53, and #54 and
the results are not as promising as I initially thought. The performance degraded because most of the conversions (serdes) are being handled in JS, which slows things down. As shown below the number of messages produced dropped by %14. However,the introduction of theSchemaRegistry
client seems to help create and retrieve schemas much easier, which comes at a cost. Maybe I should find a better way or develop the extension as is while exposing more configuration of the schema registry client and the serdes. 🤷This is the result, as of now:
The following is the result of running the
test_json.js
for a minute with 50 VUs.The text was updated successfully, but these errors were encountered: