This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can just switch to ioredis, and remove the need for passing in the |
If you can do the merge & release today, I'm updating the PR. |
behrad
changed the title
Let ioredis options in by redisOptions key
Introduce ioredis & msgpack
Apr 28, 2016
This should not affect current deployments despite the configuration change. |
Would you please check this @mcollina ? Fails seem not be related to this commit |
I have not much time to look into it. It seems some incompatibility somewhere in node v0.12 :(. |
Merged
seems a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis persistence is compatible with ioredis, when requiring ioredis constructor in.
Options can be set via redisOptions