Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Introduce ioredis & msgpack #146

Merged
merged 7 commits into from
May 21, 2016
Merged

Introduce ioredis & msgpack #146

merged 7 commits into from
May 21, 2016

Conversation

behrad
Copy link
Contributor

@behrad behrad commented Apr 21, 2016

Redis persistence is compatible with ioredis, when requiring ioredis constructor in.
Options can be set via redisOptions

@mcollina
Copy link
Collaborator

I think we can just switch to ioredis, and remove the need for passing in the 'redis' module. This is a tiny breakage (will bump the major), but I think it's way better. We'll need to update the docs in mosca.

@behrad
Copy link
Contributor Author

behrad commented Apr 23, 2016

If you can do the merge & release today, I'm updating the PR.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage increased (+0.06%) to 91.478% when pulling 32d3663 on adpdigital:master into 135dce3 on mcollina:master.

@behrad behrad changed the title Let ioredis options in by redisOptions key Introduce ioredis & msgpack Apr 28, 2016
@behrad
Copy link
Contributor Author

behrad commented Apr 28, 2016

This should not affect current deployments despite the configuration change.
All redis options are now passed flat to the ascoltatori.

@behrad
Copy link
Contributor Author

behrad commented Apr 29, 2016

Would you please check this @mcollina ? Fails seem not be related to this commit

@mcollina
Copy link
Collaborator

mcollina commented May 2, 2016

I have not much time to look into it. It seems some incompatibility somewhere in node v0.12 :(.
We can't drop that, unfortunately.

@mcollina mcollina mentioned this pull request May 3, 2016
@behrad
Copy link
Contributor Author

behrad commented May 12, 2016

seems a microtime build error when building leveldown!!

@mcollina mcollina merged commit 32d3663 into moscajs:master May 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants