Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

added kafka ascoltatore #144

Merged
merged 26 commits into from
May 21, 2016
Merged

added kafka ascoltatore #144

merged 26 commits into from
May 21, 2016

Conversation

fullergalway
Copy link
Contributor

No description provided.

@fullergalway
Copy link
Contributor Author

The travis build server needs kafka + zookeeper instances running for this to build.
http://kafka.apache.org/documentation.html#quickstart

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 92.083% when pulling 983440a on fullergalway:kafka into 135dce3 on mcollina:master.

"hello_42_there",
{topic: "hello_42", encoding: "utf8"},
{topic: "image", encoding: "buffer"}
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the kind of behavior that should be handled inside Ascoltatori. Topics should be created automatically by the library, rather than predefined in the configuration.

@mcollina
Copy link
Collaborator

Impressive work! Thanks so much for contributing this, I have added a comments, mostly on the API/configuration side.

var offset = new kafka.Offset(client);
offset.fetch(partitions, function (err, data) {
var offsets = [];
//TODO handle err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err should be handled

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 92.088% when pulling 6389c7e on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 1de2ca2 on fullergalway:kafka into 135dce3 on mcollina:master.

@fullergalway
Copy link
Contributor Author

Not sure why some of those CI tests are failing for mongodb sometimes, or how it could be related to any changes I made....

  1. ascoltatori.MongoAscoltatore should unsubscribe from wildcard topics independently:
    Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling def785c on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 205b5b5 on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 48a9dde on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling c6953fb on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 39553bb on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 97f462d on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling ca23053 on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 80be903 on fullergalway:kafka into 135dce3 on mcollina:master.

@mcollina
Copy link
Collaborator

mcollina commented Apr 6, 2016

So, we need node v0.12 support and old MongoDB support, but don't care too much about MongoDB. Regarding 0.12, just care about Kafka support.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 3c00497 on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling db3a6be on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 473e841 on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 42913aa on fullergalway:kafka into 135dce3 on mcollina:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 90.576% when pulling 680c7fb on fullergalway:kafka into 135dce3 on mcollina:master.

@mcollina mcollina mentioned this pull request May 3, 2016
@mcollina mcollina merged commit 680c7fb into moscajs:master May 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants