Do we still need the external accrueInterest

[MathisGD]

With #171 merged, do we still need this external function ?

https://github.com/morpho-labs/morpho-blue/blob/453c185ec94587143240ea234977509bdcc20d9f/src/Morpho.sol#L436-L441

[Rubilmax]

#171 is to be used inside view contexts, while external accrueInterest avoids having to do the calculation twice in a non-view context (e.g. an ERC4626 on top when checking for maxWithdraw)

So I'm for keeping both

[MathisGD]

isn't maxWithdraw view ?

Edit: yes https://eips.ethereum.org/EIPS/eip-4626#maxwithdraw

Edit1: I agree that there might be some use-cases, but it might be a little bit niche

[Rubilmax]

isn't maxWithdraw view ?

Yes, but you could want, upon withdraw, to override the default ERC4626's behavior by first accruing interest (optimistically), then calculate maxWithdraw with actual values (that are up-to-date)

It's a niche example I agree, can't we think of another similar which motivates keeping both?
It'll never be strictly necessary to have both, but I find it quite ok to have them both

[MathisGD]

Yes, but you could want, upon withdraw, to override the default ERC4626's behavior by first accruing interest (optimistically), then calculate maxWithdraw with actual values (that are up-to-date)

in practice you would maxWithdraw the shares but ok you could

[MathisGD]

@QGarchery is highlighting me that this function can be useful to make a contract to help feeReceiver withdrawMax (but literally useful to one person so I don't think it's worth it)

[MerlinEgalite]

Discussed with @PaulFrambot, we're having a hard time to find a usecase for this function. So I think we should remove it.