Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get-apres and delete-apires more efficient #1

Open
morningspace opened this issue Apr 17, 2021 · 0 comments
Open

Make get-apres and delete-apires more efficient #1

morningspace opened this issue Apr 17, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@morningspace
Copy link
Owner

get-apires and delete-apires is very helpful when you want to clean up resources in a namespace before you delete the namespace, otherwise, it's very easy to lead to the deleted namespace keeping in terminating status.

But the current implementation will have iterator each api-resource inside the namespace one by one, and in order to get the number of instances being processed for each resource, it make an call against the resource, so there will be twice kubectl calls for each resource. This makes the overall run a bit slow.

Also, it prints message even there's no instances for a particular resource. In some cases, it may be a bit annoying if I just want to know which resources really have instances and are processed.

@morningspace morningspace added enhancement New feature or request help wanted Extra attention is needed labels Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant