Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #648 - enabled any css selector #651

Merged
merged 4 commits into from
Jan 31, 2023
Merged

feat: #648 - enabled any css selector #651

merged 4 commits into from
Jan 31, 2023

Conversation

mauroerta
Copy link
Collaborator

Proposed changes

Enables the usage of any CSS selectors into the Morfeo Style Object:

const useClasses = createUseClasses({
   p: 'm',
   '& > p': {
      color: 'text'
   },
});

Closs #648

Types of changes

  • 🐛 Bugfix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality or enhancements)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ✅ Tests (added tests for an existing feature)
  • 📚 Documentation Update (if none of the other choices apply)
  • 🙌 Other (please, write a clear and concise description of the proposal in the section above)

Checklist

  • 👀 I have read the CONTRIBUTING doc
  • ✅ Lint and unit tests pass locally with my changes
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • 📚 I have added the necessary documentation (if appropriate)
  • 🔀 Any dependent changes have been merged and published in downstream modules

Further comments

Also fixes:

  • media queries for values that are not handled by any parser
  • media queries resolution

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d1cc87e) compared to base (de8051c).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          112       111    -1     
  Lines         1035      1048   +13     
  Branches       153       159    +6     
=========================================
+ Hits          1035      1048   +13     
Impacted Files Coverage Δ
packages/cli/src/utils/getClassesCSS.ts 100.00% <ø> (ø)
packages/cli/src/utils/parseSlice.ts 100.00% <ø> (ø)
packages/babel-plugin/src/utils/splitStyles.ts 100.00% <100.00%> (ø)
packages/core/src/parsers/createParsers.ts 100.00% <100.00%> (ø)
packages/core/src/theme/createTheme.ts 100.00% <100.00%> (ø)
packages/core/src/utils/parseNumber.ts 100.00% <100.00%> (ø)
packages/jss/src/generateClassName.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mauroerta mauroerta merged commit 5980606 into main Jan 31, 2023
@mauroerta mauroerta deleted the feat/648 branch January 31, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants