-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@todo and @async tags are not highlighted in a JSDoc comment block #493
Comments
Many other tags are not highlighted like @file and @overview which are synonyms to @fileoverview. The detected tag list is clearly incomplete and needs to be updated with the entire tag set. In js2-mode.el, lines 6835 to 6939, their is the list of detected tags. I've tried to add @file and @overview in the regexp Any idea of how to update the tag set ? |
I took a crack at updating and re-ordering some of the JSDoc tags based on what's enumerated on http://usejsdoc.org/index.html , because I too just noticed this behavior with diff: orzechowskid@ad9575e If there's interest in me opening a PR, then I will gladly sign the release form and do so. |
In my current install I see the added regexp-opt — was your change merged (so this issue could be closed)? |
@ArneBab Still no "async" or "todo" tags in master. @orzechowskid PR welcome, sure. |
Some of these missing tags are buggin' me too. I've got it patched on my end. When I get some time I'd like to go over the JSDoc3 tag list and update js2-mode in a more complete way than just the "one or two tags I feel like I'm missing." Some non JSDoc tags that I'd also like to add are weirder ones like "@template" for describing generics to the TypeScript language server without the use of TypeScript. Is it OK if I do that? |
Is there a way to use js2 for Typescript? At work we’re migrating there and the ts-lsp and tide-mode just don’t have the same performance as js2-mode. |
You could just use typescript.el + lsp-mode with the typescript language server. Works well for me. https://github.com/emacs-typescript/typescript.el |
There was a project to extend js2-mode to support Flow, but it's stalled: https://github.com/Fuco1/flow-js2-mode There's nothing comparable for TS, to my knowledge. |
I guess so. You could add a separate regexp for them, like |
Hi! The
@todo
tag and @async tag are not highlighted in a JSDoc comment block like other tags are. Could they be included into the list of supported tags?The text was updated successfully, but these errors were encountered: