New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort non-numeric votes #80

Closed

diedexx wants to merge 1 commit into moorscode:main from diedexx:group-votes

Contributor

diedexx commented Sep 7, 2021

fixes #79

Some relevant choices:

I kept the sorting client-side.
If the current vote values are the same, I sort on the initial value. It felt more natural/logical to me when testing.
I made the voteSorting service a TS file, so it can be unittested. The current Jest setup couldn't deal with ES6 .js files.
I added a description key to the Jest each table. They're not used in the test, but are shown when a test case fails. This helps with debugging


          Sort non-numeric votes

6c74436

Owner

moorscode commented Feb 8, 2023

This has been merged 😅

moorscode closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet