Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Suggestions #36

Open
eliottmusk opened this issue Oct 17, 2024 · 3 comments
Open

Some Suggestions #36

eliottmusk opened this issue Oct 17, 2024 · 3 comments

Comments

@eliottmusk
Copy link

eliottmusk commented Oct 17, 2024

Please add:

1 - Dark Theme

2 - A way to delete all history and to delete each history item separately

3 - A setting to disable the history completely, so to not store any history

4 - Options to copy or save the generated QR code

5 - Scan QR in Image never work to me, the plugin need be more flexible, and search for QRs in images with more objects and people etc.

6 - Add a Quick Region Scan, so if you use Alt + Left Click the plugin scan the cursor region and open the URL in a new background (or optionally foreground) tab without any popup, confirmation, just click and open, this Quick mode is to use QRs as a type of link.

7 - Better performance for white codes in black backgrounds

Thanks!

@monyxie
Copy link
Owner

monyxie commented Oct 18, 2024

Thanks for the suggestions.

1 - Dark Theme

I thought about it in the past. I decided to give up the idea for that the QR code needs a near-white background to achieve maximum readability and that would defeat the purpose of a dark theme.

2 - A way to delete all history and to delete each history item separately

This is a good idea. I'll see what I can do.

3 - A setting to disable the history completely, so to not store any history

Also a good idea.

4 - Options to copy or save the generated QR code

You can already do that via the "Save" and "Copy" buttons right below the generated QR code.

5 - Scan QR in Image never work to me, the plugin need be more flexible, and search for QRs in images with more objects and people etc.

The QR code reader has a high chance of failing when trying to reading very small QR codes in large images. This is a limitation of the underlying library so it's unlikely that we will see any changes. You'll have to use the "Select region to scan" feature to scan these kind of images.

"Scan QR in Image" feature could also fail if the extension is not allowed to read the image data. Please provide more detail so I can determine if this is the case.

6 - Add a Quick Region Scan, so if you use Alt + Left Click the plugin scan the cursor region and open the URL in a new tab without any popup, confirmation, just click and open, this Quick mode is to use QRs as a type of link.

This sounds like an interesting idea. However listening for mouse clicks would require injecting a script into every single web page the user visits, which is something I'm actively trying to avoid. Additionally, altering left click behavior (even with a modifier key) would likely cause problems on websites that already do that themselves.

For the above reasons I don't think this feature is worth implementing.

7 - Better performance for white codes in black backgrounds

This is also a limitation of the underlying library. However I'll see if I can do something to improve sucess rate on my side.

@eliottmusk
Copy link
Author

First thanks your attention and answers, about dark theme and if you keep white background just on QR code and make the QR small when in Dark Theme? About Save and Copy buttons I can't see both, but I think is because I use "layout.css.devPixelsPerPx: 1.4". About Quick Region Scan, some alternatives would be keep this feature optional and turned off by default, so if the user don't enable it the plugin don't inject anything, and also add a blacklist to exclude sites that has some conflict like "Yet Another Smooth Scrolling WE" plugin. Thank you!

@eliottmusk
Copy link
Author

alt + right click = open qr code link in current tab

alt + shift + right click = open in a new background tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants