This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Allow overriding fallback paths for MSBuildExtensionsPath via a property #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
approved these changes
May 14, 2018
Currently, the list of fallback paths in app.config can have a property reference, like: ``` <searchPaths os="osx"> <property name="MSBuildExtensionsPath" value="$(FallbackPath);/x/y/z" /> ``` .. but it is assumed that such a property will expand to a single path. This commit adds support for such properties to expand to multiple ';' separated list of paths. The rules for expansion do not change, they are still expanded at the time of project import. With this, given `$(FallbackPath)="/a/b/c;/q/w/e"` and the list of fallback paths would become `"/a/b/c;/q/w/e;/x/yz"`.
.. MSBuildExtensionsPath. For OSX, this essentially sets the fallback paths to: `<property name="MSBuildExtensionsPath" value="$(MSBuildExtensionsPathFallbackPathsOverride);/Library/Frameworks/Mono.framework/External/xbuild/" />` .. whichs allows the default fallback paths to be overridden by setting a property - `$(MSBuildExtensionsPathFallbackPathsOverride)`. One of the useful use cases for this is to be able to run tests with in-tree builds of assemblies/targets meant for `$(MSBuildExtensionsPath)/`. Simply changing `$(MSBuildExtensionsPath)` would mean that the in-tree builds of the custom frameworks would work but the default ones would not be found!
radical
force-pushed
the
extn-fallback-override-mono
branch
from
3c6ccea
to
98ad643
Compare
This was referenced May 21, 2018
radical
added a commit
that referenced
this pull request
Sep 26, 2018
… a property (#59)" (#75) This reverts commit c4e70a6. This was not accepted upstream. Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/682034
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
MSBuildExtensionsPathfallback paths to be overridden by setting$(MSBuildExtensionsPathFallbackPathsOverride), without having to touch theapp.config .