From fcf277bbf4200d70fb5d992b4384044abd76efe3 Mon Sep 17 00:00:00 2001
From: Seamus Lee <seamuslee001@gmail.com>
Date: Wed, 1 Mar 2017 14:45:14 +1100
Subject: [PATCH] CRM-20201 Fix issue where manage tags page would not display
 properly if tag set does not have a created by set

---
 CRM/Tag/Page/Tag.php           | 4 +++-
 templates/CRM/Tag/Page/Tag.tpl | 9 ++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/CRM/Tag/Page/Tag.php b/CRM/Tag/Page/Tag.php
index 53066650b544..1c98beca0462 100644
--- a/CRM/Tag/Page/Tag.php
+++ b/CRM/Tag/Page/Tag.php
@@ -63,7 +63,9 @@ public function run() {
     foreach ($result['values'] as $id => $tagset) {
       $used = explode(',', CRM_Utils_Array::value('used_for', $tagset, ''));
       $tagset['used_for_label'] = array_values(array_intersect_key($usedFor, array_flip($used)));
-      $tagset['display_name'] = $tagset['created_id.display_name'];
+      if (isset($tagset['created_id.display_name'])) {
+        $tagset['display_name'] = $tagset['created_id.display_name'];
+      }
       unset($tagset['created_id.display_name']);
       $tagsets[$id] = $tagset;
     }
diff --git a/templates/CRM/Tag/Page/Tag.tpl b/templates/CRM/Tag/Page/Tag.tpl
index 2a522df4c544..fe4560ca8f82 100644
--- a/templates/CRM/Tag/Page/Tag.tpl
+++ b/templates/CRM/Tag/Page/Tag.tpl
@@ -81,9 +81,11 @@
       function formatTagSet(info) {
         info.date = CRM.utils.formatDate(info.created_date);
         info.used_for_label = [];
-        _.each(info.used_for.split(','), function(item) {
-          info.used_for_label.push(usedFor[item]);
-        });
+        if (undefined !== info.used_for) {
+          _.each(info.used_for.split(','), function(item) {
+            info.used_for_label.push(usedFor[item]);
+          });
+        }
       }
 
       _.each(tagSets, formatTagSet);
@@ -471,6 +473,7 @@
 <script type="text/template" id="tagsetHelpTpl">
   <div class="help">
     <% if(is_reserved == 1) {ldelim} %><strong>{ts}Reserved{/ts}</strong><% {rdelim} %>
+    <% if(undefined === display_name) var display_name = null; %>
     {ts 1="<%= used_for_label.join(', ') %>" 2="<%= date %>" 3="<%= display_name %>"}Tag Set for %1 (created %2 by %3).{/ts}
     <% if(typeof description === 'string' && description.length) {ldelim} %><p><em><%- description %></em></p><% {rdelim} %>
   </div>