it should not persist blank strings, but it does

[lucasrenan]

I found a bug when trying to create a slug with a blank field, mongoid-slug stores a blank string broking to_param method.
Check it out https://github.com/lucasrenan/mongoid-slug/blob/master/spec/mongoid/slug_spec.rb#L28 (this test is still failing).

So, could you give any advice how should I fix this bug? I tried to include a condition for build_slug method. however, it wasn't a good idea.

Thanks.

[digitalplaywright]

It was not my intention to close this pull request. I just wanted to merge it with master.

To answer your question I think the appropriate place to fix this is build_slug

• https://github.com/digitalplaywright/mongoid-slug/blob/master/lib/mongoid/slug.rb#L132

Since a user can define custom slug id strategies it can not be assumed that the slug is a string. Like e.g the strategy here:

• https://github.com/digitalplaywright/mongoid-slug/blob/master/lib/mongoid/slug/slug_id_strategy.rb

Please let me know if you have any thoughts on how you think this issue is best fixed.

[lucasrenan]

it's not crear for me this "slug id strategies". can you give me an example?
thanks.

[digitalplaywright]

Look at the "Custom Find Strategies" section in the README.md for an example:

• https://github.com/digitalplaywright/mongoid-slug

[digitalplaywright]

This is now fixed on master. Thank you for reporting this issue.

[lucasrenan]

👍