From 06570e6d7aa56a06fbd84e962e8c69347cd60fa5 Mon Sep 17 00:00:00 2001 From: Oriol Arbusi Date: Tue, 7 Jan 2025 14:30:22 +0100 Subject: [PATCH] remove unnecessary CI var --- .github/workflows/acceptance-tests-runner.yml | 4 ---- .github/workflows/acceptance-tests.yml | 1 - internal/testutil/acc/pre_check.go | 3 +-- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/acceptance-tests-runner.yml b/.github/workflows/acceptance-tests-runner.yml index a8360f470a..440b66f97e 100644 --- a/.github/workflows/acceptance-tests-runner.yml +++ b/.github/workflows/acceptance-tests-runner.yml @@ -98,9 +98,6 @@ on: mongodb_atlas_flex_project_id: type: string required: true - mongodb_atlas_stream_aws_pl_project_id: - type: string - required: true confluent_cloud_network_id: type: string required: true @@ -1074,7 +1071,6 @@ jobs: AWS_ACCOUNT_ID: ${{ secrets.aws_account_id }} CONFLUENT_CLOUD_API_KEY: ${{ secrets.confluent_cloud_api_key }} CONFLUENT_CLOUD_API_SECRET: ${{ secrets.confluent_cloud_api_secret }} - MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID: ${{ inputs.mongodb_atlas_stream_aws_pl_project_id }} CONFLUENT_CLOUD_NETWORK_ID: ${{ inputs.confluent_cloud_network_id }} CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID: ${{ inputs.confluent_cloud_privatelink_access_id }} ACCTEST_PACKAGES: | diff --git a/.github/workflows/acceptance-tests.yml b/.github/workflows/acceptance-tests.yml index 38925c72c3..a31de24afe 100644 --- a/.github/workflows/acceptance-tests.yml +++ b/.github/workflows/acceptance-tests.yml @@ -120,6 +120,5 @@ jobs: azure_private_endpoint_region: ${{ vars.AZURE_PRIVATE_ENDPOINT_REGION }} mongodb_atlas_rp_org_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_RP_ORG_ID_QA || vars.MONGODB_ATLAS_RP_ORG_ID_DEV }} mongodb_atlas_flex_project_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_FLEX_PROJECT_ID_QA || vars.MONGODB_ATLAS_FLEX_PROJECT_ID }} - mongodb_atlas_stream_aws_pl_project_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID_QA || vars.MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID }} confluent_cloud_network_id: ${{ vars.CONFLUENT_CLOUD_NETWORK_ID }} confluent_cloud_privatelink_access_id: ${{ vars.CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID }} diff --git a/internal/testutil/acc/pre_check.go b/internal/testutil/acc/pre_check.go index 3ceee361f5..1dcb7d39a2 100644 --- a/internal/testutil/acc/pre_check.go +++ b/internal/testutil/acc/pre_check.go @@ -367,9 +367,8 @@ func PreCheckConfluentAWSPrivatelink(tb testing.TB) { tb.Helper() if os.Getenv("CONFLUENT_CLOUD_API_KEY") == "" || os.Getenv("CONFLUENT_CLOUD_API_SECRET") == "" || - os.Getenv("MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID") == "" || os.Getenv("CONFLUENT_CLOUD_NETWORK_ID") == "" || os.Getenv("CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID") == "" { - tb.Fatal("`CONFLUENT_CLOUD_API_KEY`, `CONFLUENT_CLOUD_API_SECRET`, `MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID`, `CONFLUENT_CLOUD_NETWORK_ID`, and `CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID` must be set for Cloud Backup Snapshot Export Bucket acceptance testing") + tb.Fatal("`CONFLUENT_CLOUD_API_KEY`, `CONFLUENT_CLOUD_API_SECRET`, `CONFLUENT_CLOUD_NETWORK_ID`, and `CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID` must be set for Cloud Backup Snapshot Export Bucket acceptance testing") } }