Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5495): do not emit deprecation warning when tlsCertificateKeyFile is specified and tlsCertificateFile is not #3810

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 10, 2023

Description

What is changing?

This PR prevents the driver from emitting a deprecation warning when tlsCertificateKeyFile is specified and tlsCertificateFile is not.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Release Highlight

Fixed accidental deprecation warning

Because of internal options handling, a deprecation was emitted for tlsCertificateFile when using tlsCertificateKeyFile. That has been corrected.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title feat(NODE-5429): deprecate the AutoEncrypter interface (#3764) fix(NODE-5495): do not emit deprecation warning when tlsCertificateKeyFile is specified and tlsCertificateFile is not Aug 10, 2023
src/connection_string.ts Show resolved Hide resolved
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 11, 2023
@nbbeeken nbbeeken self-assigned this Aug 11, 2023
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 14, 2023
@nbbeeken nbbeeken merged commit e81d4a2 into 5.x Aug 15, 2023
@nbbeeken nbbeeken deleted the NODE-5495-5.x-branch branch August 15, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants