feat(NODE-3695)!: remove lastop and optime from bulk result #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
baileympearson
added
the
Primary Review
baileympearson
previously approved these changes
Jan 3, 2023
| @@ -1,132 +0,0 @@ | |||
| /* eslint-disable no-loss-of-precision */ | |||
| /* eslint-disable @typescript-eslint/no-loss-of-precision */ | |||
| // TODO(NODE-3774): Lower the integer literals below JS max precision | |||
There was a problem hiding this comment.
Can we safely close the linked TODO? I think so 🙂
There was a problem hiding this comment.
Agree - closed that ticket now.
nbbeeken
previously approved these changes
Jan 3, 2023
baileympearson
approved these changes
Jan 3, 2023
nbbeeken
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
lastOp()andopTimefrom bulk results.What is changing?
opTimefrom bulk result.lastOp()from bulk result.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-3695
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript