Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3818)!: remove slaveOk options #3503

Merged
merged 4 commits into from
Jan 3, 2023
Merged

feat(NODE-3818)!: remove slaveOk options #3503

merged 4 commits into from
Jan 3, 2023

Conversation

durran
Copy link
Member

@durran durran commented Dec 27, 2022

Description

Removes the slaveOk option from the codebase.

What is changing?

  • Removes the slaveOk option and method from the Collection class.
  • Updates migration guide.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-3818

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken self-requested a review January 3, 2023 14:54
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 3, 2023
nbbeeken
nbbeeken previously approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 3, 2023
@nbbeeken nbbeeken merged commit 2e28009 into main Jan 3, 2023
@nbbeeken nbbeeken deleted the NODE-3818 branch January 3, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @nbbeeken