Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-3482)!: remove unref #3494

Merged
merged 4 commits into from
Dec 22, 2022
Merged

feat(NODE-3482)!: remove unref #3494

merged 4 commits into from
Dec 22, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 20, 2022

Description

What is changing?

Remove unref no-op stubs

What is the motivation for this change?

Code clean up

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review December 21, 2022 16:02
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a 5.0 changes conflict to be fixed.

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 21, 2022
@nbbeeken nbbeeken requested a review from durran December 21, 2022 16:41
durran
durran previously approved these changes Dec 21, 2022
@durran durran merged commit 556812f into main Dec 22, 2022
@durran durran deleted the NODE-3482-rm-unref branch December 22, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants