feat(NODE-4078): allow comment with estimated doc count #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
added
the
Primary Review
baileympearson
previously approved these changes
Jun 27, 2022
bajanam
added
Team Review
dariakp
requested changes
Jun 27, 2022
| @@ -0,0 +1,31 @@ | |||
| import { expect } from 'chai'; | |||
|
|
|||
| describe('Collection', () => { | |||
There was a problem hiding this comment.
If we're going to add an integration test for this, I think we should add it with the others. Adding tests for all falsy values should be as easy as adding ['estimatedDocumentCount', { } ] to the array of commands here:
There was a problem hiding this comment.
I've moved over to that test.
baileympearson
requested changes
Jun 29, 2022
test/integration/node-specific/comment_with_falsy_values.test.ts
Outdated
Show resolved
Hide resolved
baileympearson
previously approved these changes
Jun 30, 2022
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
|
@baileympearson I committed your suggestion. Just waiting on evg run now. |
baileympearson
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows comment to be provided with estimated document count.
What is changing?
Sets the comment on the command and adds the new unified tests.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4078
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>