fix(NODE-3511): deprecate fullResponse and remove associated buggy code paths #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
the
Primary Review
dariakp
changed the title
nbbeeken
reviewed
Aug 20, 2021
nbbeeken
reviewed
Aug 20, 2021
nbbeeken
added
Team Review
emadum
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3511
What changed?
Removing the never properly implemented
fullResponseoption from the codebase, also markingCommandOptionsinternal, since they are, in fact, internal use only. Also, removing the ability to externally affect thefullResultoption (TS compilation would break iffullResultis passed in as a command option, but nothing is stopping regular js users from setting it and overriding our internal settings - we should confirm with shell that they aren't using it for some niche functionality, but otherwise this should be safe to disable)