fix(url_parser): support a default database on mongodb+srv uris

NODE-1321
mongodb · Mar 23, 2018 · 6d39b2a · 6d39b2a
1 parent 02729dc
commit 6d39b2a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/url_parser.js b/lib/url_parser.js
@@ -63,6 +63,16 @@ module.exports = function(url, options, callback) {
     let connectionString = connectionStrings.join(',') + '/';
     let connectionStringOptions = [];
 
+    // Add the default database if needed
+    if (result.path) {
+      let defaultDb = result.path.slice(1);
+      if (defaultDb.indexOf('?') !== -1) {
+        defaultDb = defaultDb.slice(0, defaultDb.indexOf('?'));
+      }
+
+      connectionString += defaultDb;
+    }
+
     // Default to SSL true
     if (!options.ssl && !result.search) {
       connectionStringOptions.push('ssl=true');

diff --git a/test/functional/mongodb_srv_tests.js b/test/functional/mongodb_srv_tests.js
@@ -14,7 +14,14 @@ function getTests() {
     .map(x => [path.basename(x[0], '.json'), JSON.parse(x[1])]);
 }
 
-describe('DNS and TXT record tests', function() {
+describe('mongodb+srv (spec)', function() {
+  it('should parse a default database', function(done) {
+    parse('mongodb+srv://test5.test.build.10gen.cc/somedb', (err, result) => {
+      expect(result.dbName).to.eql('somedb');
+      done();
+    });
+  });
+
   getTests().forEach(function(test) {
     if (!test[1].comment) test[1].comment = test[0];