feat(NODE-6086): add Double.fromString() method #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
aditi-khare-mongoDB
changed the title
baileympearson
added
the
Primary Review
| * | ||
| * @param value - the string we want to represent as an double. | ||
| */ | ||
| static fromString(value: string): Double { |
There was a problem hiding this comment.
same comment here as on the Int32.fromString() PR: can we throw descriptive errors for each case we're checking for in the if statement?
There was a problem hiding this comment.
Yep, on it
test/node/double.test.ts
Outdated
|
|
||
| for (const [testName, value, expectedDouble] of acceptedInputs) { | ||
| context(`when case is ${testName}`, () => { | ||
| it(`should return Double that matches expected value`, () => { |
There was a problem hiding this comment.
Same comment here about test titles.
There was a problem hiding this comment.
Just changed them, going to push after my tests run!
baileympearson
approved these changes
Apr 18, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add static
Double.fromString()method.What is changing?
Is there new documentation needed for these changes?
Yes, there are new API docs.
What is the motivation for this change?
NODE-3660 user ticket, our validation in the Double is lacking. In V7, we will add
Double.fromString(value)validation call into theDoubleconstructor'sstringcase.Release Highlight
Add static
Double.fromStringmethodThis method attempts to create an
Doubletype from a string, and will throw aBSONErroron any string input that is not representable as aIEEE-754 64-bit double.Notably, this method will also throw on the following string formats:
'Infinity','-Infinity', and'NaN'input strings are still allowed)Strings with leading zeros, however, are also allowed.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript