Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5002): cloned cursors are not legacy api #11

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Jan 23, 2023

Description

What is changing?

Fix cloned cursors not being transformed to legacy instances.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title fix(NODE-4988): cloned cursors are not legacy api fix(NODE-5003): cloned cursors are not legacy api Jan 24, 2023
@nbbeeken nbbeeken changed the title fix(NODE-5003): cloned cursors are not legacy api fix(NODE-5002): cloned cursors are not legacy api Jan 24, 2023
durran
durran previously approved these changes Jan 25, 2023
@durran durran marked this pull request as ready for review January 25, 2023 15:01
test/unit/legacy_wrappers/collection.test.js Outdated Show resolved Hide resolved
test/unit/legacy_wrappers/db.test.js Outdated Show resolved Hide resolved
Co-authored-by: Warren James <28974128+W-A-James@users.noreply.github.com>
@durran durran merged commit 5413962 into main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants