Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4957): Missing callback typings for insertOne method #10

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(NODE-4957): Missing callback typings for insertOne method #10

merged 1 commit into from
Jan 17, 2023

Conversation

xxxLukskyxxx
Copy link
Contributor

@xxxLukskyxxx xxxLukskyxxx commented Jan 16, 2023 •
edited
Loading

Description

The insertOne method cannot be used in Typescript with callbacks because the callback typings are missing.

What is changing?

Adding the missing callback typings for the insertOne method in mongo-legacy.d.ts.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

The possibility to use the insertOne method with callbacks.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@xxxLukskyxxx
Added callback typings for the insertOne method
9b48a0b 
Adding the missing callback typings for the insertOne method in mongo-legacy.d.ts
@xxxLukskyxxx
Copy link
Contributor Author

npm run check:test does not throw any errors on my machine

baileympearson
baileympearson approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks for the fix!

nbbeeken
nbbeeken approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for the help! LGTM

@baileympearson baileympearson merged commit 613e4b7 into mongodb-js:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxxLukskyxxx @nbbeeken @baileympearson