This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
fix(transactions): do not send txnNumber for non-write commands #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started sending txnNumber for non-transaction non-retryable commands, which causes errors against transaction-enabled servers Fixes NODE-1466
|
Hmmm, I think this should have been caught in at least one of the transactions spec tests. I'll check and add one that confirms drivers don't send txnNumber for non-transaction commands. For now, can you add a test to confirm your fix? |
|
@ShaneHarvey will do. |
|
@ShaneHarvey added unit tests |
ShaneHarvey
approved these changes
May 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started sending txnNumber for non-transaction non-retryable
commands, which causes errors against transaction-enabled servers
Fixes NODE-1466