test(models): add basic tests for models #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoNero
force-pushed
the
add/tests-for-models
branch
2 times, most recently
from
1e62131
to
b6e6a6a
Compare
|
Can you give some description for why you are testing these? |
|
@TheCharlatan just updated the description |
|
There are some conflicts. Sorry, I was on my phone and lacked some larger context. I now see you are testing all the manual impl , which I think makes sense. |
LeoNero
force-pushed
the
add/tests-for-models
branch
from
b6e6a6a
to
7900386
Compare
|
done |
TheCharlatan
approved these changes
Jul 13, 2022
refring
pushed a commit
to refring/monero-rpc-rs
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic tests for
They may seem redundant since there wasn't much to be tested, but having unit tests to make sure things work as expected and no "innocent" change mess up with things, is always good.