Fix humanize #1642
Merged
Fix humanize #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like #1663 is in (obvious) conflict with my code. I have to rebase it. |
|
Looks good to me. Merge whenever you want :) |
ichernev
added a commit
that referenced
this pull request
Jun 19, 2014
Fix humanize @changelog @section bugfix @description use duration object for relative duration strings @Breaking relativeTimeThreshold keys are now changed to 's', 'm', 'h', 'd' and 'M'. Also the actual thresholds for changed (46 days is now 1 month, not 2).
Menelion
pushed a commit
to Menelion/moment
that referenced
this pull request
Jul 6, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1620
There are a few things going on here
@icambron maybe a careful code review, I'll fix the tests at some point in the future.