Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent release documentation #827

Closed
gilmoreorless opened this issue Mar 29, 2020 · 1 comment
Closed

Inconsistent release documentation #827

gilmoreorless opened this issue Mar 29, 2020 · 1 comment

Comments

@gilmoreorless
Copy link
Member

This repository is giving conflicting data about releases 0.5.28 and 0.5.29.

The new country-related methods (moment.tz.countries() and friends) are available from 0.5.28 onwards. This is currently the latest available published version on npm.

However, changelog.md says that these features were added in 0.5.29 (which hasn't yet been released). It has also missed version 0.5.27:

image

The releases page on GitHub says that it's both 0.5.28 and 0.5.29:

image

It's hard to tell which version these features are intended to be in, since the commit that updated the changelog (d7f687e) also includes feature changes that aren't mentioned.

@gilmoreorless
Copy link
Member Author

Part of the changelog was fixed by #845. I've now corrected the release dates of a couple of others in 5162f1d.

I've also added git tags for 0.5.29 and 0.5.30 (as they were previously missing), and updated the Releases page to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants