Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonisation matrix for repeated variable displayed incorrectly #4286

Open
hslh opened this issue Sep 30, 2024 · 5 comments · May be fixed by #4399
Open

Harmonisation matrix for repeated variable displayed incorrectly #4286

hslh opened this issue Sep 30, 2024 · 5 comments · May be fixed by #4399
Assignees
Labels
priority Features/bugs that we should not let wait ssr-catalogue

Comments

@hslh
Copy link
Contributor

hslh commented Sep 30, 2024

What version of EMX2 are you using (see footer)
v11.15.3

Describe the bug
The harmonisation matrix is missing information, currently it's a series of rows with just the name of the cohort. It should be a matrix with the repeats of the variable in the rows and the resource name(s) as column(s), with cells containing mapping status.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://emx2.dev.molgenis.org/catalogue/ssr-catalogue/all/variables/'
  2. Find the 'asthma_' variable and click on it. Click on 'asthma_'
  3. Scroll down to 'Harmonisation status per data source'
  4. See error

Expected behavior
Show a matrix with the repeats of the variable in the rows and the resource name(s) as column(s), with cells containing mapping status.

Screenshots
In dev:
Screenshot 2024-09-30 at 15 48 59
In production (other data):
Screenshot 2024-09-30 at 15 49 31

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Firefox 130.0.1

Additional context:
On the variable page for variable ‘asthma_’, there are no numberings anymore, which makes the harmonisation status unclear. It’s just a list of status indicators with the name of the cohort. See: $testCatalogue/ssr-catalogue/all/variables/asthma_-LifeCycle-outcome-LifeCycle?keys={"name":"asthma_","collection":{"id":"LifeCycle"},"dataset":{"name":"outcome","collection":{"id":"LifeCycle”}}}. (test 7 step 13)

@hslh hslh changed the title On the variable page for variable ‘asthma_’, there are no numberings anymore, which makes the harmonisation status unclear. It’s just a list of status indicators with the name of the cohort. See: $testCatalogue/ssr-catalogue/all/variables/asthma_-LifeCycle-outcome-LifeCycle?keys={"name":"asthma_","collection":{"id":"LifeCycle"},"dataset":{"name":"outcome","collection":{"id":"LifeCycle”}}}. (test 7 step 13) Harmonisation matrix for repeated variable displayed incorrectly Sep 30, 2024
@mswertz
Copy link
Member

mswertz commented Oct 11, 2024

cannot reproduce

@mswertz mswertz closed this as completed Oct 11, 2024
@mswertz mswertz added the priority Features/bugs that we should not let wait label Oct 23, 2024
@BrendaHijmans
Copy link
Contributor

This is only present in the test data, because the test data is a subset of the production data. The repeated variables that do not have a repeatMax filled out, get this representation in the UI. Can thus be fixed in the test data.

@BrendaHijmans
Copy link
Contributor

#4399

@hslh hslh linked a pull request Oct 30, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Features/bugs that we should not let wait ssr-catalogue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants