Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript: add ApiRouteSchema, ApiSettingsSchema #259

Merged
merged 11 commits into from
Oct 17, 2021

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Jul 12, 2021

create and export

  • ApiRouteSchema used to define settings.routes
  • ApiSettingsSchema used to define api service's settings
    I can't remember all of them T__T
    Screen Shot 2021-07-12 at 09 48 38

api.service settings
Screen Shot 2021-07-12 at 18 31 33

@0x0a0d 0x0a0d changed the title typescript: add RouteSchema typescript: add ApiRouteSchema, ApiSettingsSchema Jul 12, 2021
@icebob icebob requested a review from shawnmcknight July 12, 2021 16:33
@0x0a0d 0x0a0d requested a review from shawnmcknight July 19, 2021 00:29
@0x0a0d
Copy link
Contributor Author

0x0a0d commented Aug 9, 2021

@icebob https://github.com/moleculerjs/moleculer-web/blob/master/src/alias.js#L63
seem only accept 1 action

aliases: {
  'POST /login': [
    'user.mustExists', // will be overwritten
    'user.passwordCompare',
  ]
}

@icebob
Copy link
Member

icebob commented Aug 9, 2021

@icebob https://github.com/moleculerjs/moleculer-web/blob/master/src/alias.js#L63
seem only accept 1 action

Yeah, you are right, it has only one action.

@icebob icebob self-requested a review August 9, 2021 12:12
@icebob
Copy link
Member

icebob commented Aug 9, 2021

@shawnmcknight could you review it again, plz?

@0x0a0d
Copy link
Contributor Author

0x0a0d commented Sep 3, 2021

hope you can merge this

@icebob
Copy link
Member

icebob commented Sep 3, 2021

I would like to wait for an approval from @shawnmcknight

@0x0a0d 0x0a0d mentioned this pull request Sep 5, 2021
@0x0a0d
Copy link
Contributor Author

0x0a0d commented Sep 21, 2021

Please merge before it outdated again

@0x0a0d
Copy link
Contributor Author

0x0a0d commented Sep 24, 2021

@shawnmcknight @icebob

@icebob icebob merged commit 4ec4b8a into moleculerjs:master Oct 17, 2021
@0x0a0d 0x0a0d deleted the improve_index_d_ts branch October 18, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants