New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateTraj passes `states` property by reference #43

Closed

braniii opened this issue Nov 9, 2023 · 0 comments

Member

braniii commented Nov 9, 2023

Describe the bug
The state trajectory class StateTraj return properties as mutable references.

To Reproduce
Steps to reproduce the behavior, including a minimal working example.

import msmhelper as mh

# prepare data
traj = mh.StateTraj(np.arange(5))

traj.states  # array([0, 1, 2, 3, 4])
traj.states += 1  # AttributeError: can't set attribute

# BUT
states = traj.states
states += 2
traj.states  # array([2, 3, 4, 5, 6])

Expected behavior
Return only copies.

Runtime information:

Version v1.1.0
Source PyPI

The text was updated successfully, but these errors were encountered:

braniii mentioned this issue

Test for immutability. #44

Merged

braniii closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment