Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch loom to dev-dependency #501

Open
Blizzara opened this issue Feb 28, 2025 · 0 comments
Open

Switch loom to dev-dependency #501

Blizzara opened this issue Feb 28, 2025 · 0 comments

Comments

@Blizzara
Copy link

Hey, thanks for making and maintaing this crate! I was looking at the dependencies it introduces downstream in my project, and among them is loom:

[[package]]
name = "moka"
version = "0.12.10"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a9321642ca94a4282428e6ea4af8cc2ca4eac48ac7a6a4ea8f33f76d0ce70926"
dependencies = [
 "async-lock",
 "crossbeam-channel",
 "crossbeam-epoch",
 "crossbeam-utils",
 "event-listener",
 "futures-util",
 "loom",
 "parking_lot",
 "portable-atomic",
 "rustc_version",
 "smallvec",
 "tagptr",
 "thiserror 1.0.69",
 "uuid",
]

However it seems that loom is only used for testing, could it be made a dev-dependency instead? Currently it's a normal dep:

[target.'cfg(moka_loom)'.dependencies]
but the lines below use dev-dependency.

I may be missing something here in case that isn't possible, but if it is it could be a nice improvement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant