fix(mojaloop/#2537): fspiop api version negotiation not handled #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdebarros
commented
Nov 5, 2021
•
mdebarros
commented
- added unit tests for config changes
- updated dependencies
- fixed audit-resolve issues
…ansfers service
- chore: updated dependencies
- updated dependencies
- add 'json-rules-engine' and 'eslint' to ncurc.json ignore file as they have breaking changes
- fixed audit-resolve issues
- added fixes for api negotiation validation
- re-factored outgoing messages by using the in-line config
- fixed unit tests
- fix(mojaloop/#2537): fspiop api version negotiation not handled - mojaloop/project#2537
- added getOptionsForFSPIOPHeaderValidation to the plugin configuration
- added new config key for PROTOCOL_VERSIONS to default and integration configs
- added DEFAULT_PROTOCOL_VERSION for backward compatibility
BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The `LIB_RESOURCE_VERSIONS` env var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.
…ests-service into fix/#2537-FSPIOP-API-version-negotiation-not-handled
mdebarros
requested review from
elnyry-sam-k,
eoln,
lewisdaly,
oderayi,
shashi165,
vgenev and
vijayg10
as code owners
elnyry-sam-k
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.