feat(services): allow local config to be used instead of redirecting to a URL #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisdaly
requested review from
eoln,
kleyow and
sridharvoruganti
as code owners
This was referenced Oct 6, 2021
kleyow
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having trouble getting the thirdparty charts integrated into the mojaloop/helm charts because of the added complexity and flakiness of using a TTK to mock out the
/servicesresource.This PR adds the ability to specify
PARTICIPANT_LIST_LOCAL, a list of participantIds that will be used in aPUT /servicescallback instead of forwarding theGET /servicesrequest to another service.It's fully backwards compatible, so if you don't set
PARTICIPANT_LIST_LOCAL, the existing behaviour (forwarding that request to some other API) will be used.