Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle unhandled promise rejections #303

Merged
merged 4 commits into from
Jun 16, 2022
Merged

fix: handle unhandled promise rejections #303

merged 4 commits into from
Jun 16, 2022

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Jun 14, 2022 •
edited
Loading

  • added catch to fire-and-forget promises that are not "handled", otherwise the nodejs process would just exit on the unhandled promise, causing the k8s pods to restart during GP tests
  • updated unit tests to correctly reject promises instead of just throwing an error (i.e. made mocked functions async), also check for rejections, and fix code-coverage issues
  • updated dependencies
  • fixed audit-resolve issues

@mdebarros
fix: handle unhandled promise rejections
45c5130 
- added catch to fire-and-forget promises that are not "handled"
- updated dependencies
mdebarros added 3 commits June 14, 2022 18:55
@mdebarros
chore: audit-resolve fixes
a7de4a6
@mdebarros
fix: added missing unhandled fire-and-forget promises
a8e6ec3 
- added missing catch on unhandled fire-and-forget promises
- updated unit tests to correctly throw a rejection instead of just throwing an error
@mdebarros
chore: improved unit tests to check for cought rejection on fire-and-…
3f22dec 
…forget promises
gibaros
gibaros approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@gibaros gibaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mdebarros mdebarros merged commit 802e627 into master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@gibaros gibaros gibaros approved these changes

@vgenev vgenev Awaiting requested review from vgenev

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@oderayi oderayi Awaiting requested review from oderayi

@shashi165 shashi165 Awaiting requested review from shashi165

@vijayg10 vijayg10 Awaiting requested review from vijayg10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdebarros @gibaros @elnyry-sam-k