-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to node LTS v16 #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gibaros, a couple of comments for your attention.
Happy to jump on a call to discuss them with you in more detail.
Also, take note:
- we need to also align the ncurc file,
- that all the checks need to pass, and
- we need to add a proper description to this PR --> please refer to the following as an example: feat(mojaloop/#2092): upgrade nodeJS version for core services central-ledger#902
…n and docker-compose files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good @gibaros, just minor comments to address.
feat(mojaloop/#2767): upgrade nodeJS version for quoting-service - mojaloop/project#2767
Notes:
BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/quoting-service which will impact config mounts.