Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to node LTS v16 #302

Merged
merged 9 commits into from
Jun 9, 2022
Merged

Conversation

gibaros
Copy link
Contributor

@gibaros gibaros commented Jun 6, 2022

feat(mojaloop/#2767): upgrade nodeJS version for quoting-service - mojaloop/project#2767

  • standardised CI scripts, however, the test-integration CI job needed minor tweaks to work with the quoting-service's implementation
  • updated docker-compose files to work correctly
  • added wait-4-docker npm script
  • fixed lint issues
  • updated .nvmrc to latest LTS version
  • added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • updated gitignore to include test/results and IGNORE patterns
  • updated README with standard auto-release information
  • Fixed imports
  • Cleaned up Package.json
  • Removed unnecessary dependencies
  • Removed unnecessary files

Notes:

  • Helm chart mountPaths need to be updated from /opt/quoting-service to /opt/app as follows:
    volumeMounts:
    - mountPath: /opt/app/config
      name: <deployment-name>

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/quoting-service which will impact config mounts.

@gibaros gibaros changed the title chore - upgrade to node LTS v16 chore: upgrade to node LTS v16 Jun 6, 2022
@gibaros gibaros changed the title chore: upgrade to node LTS v16 feat: upgrade to node LTS v16 Jun 6, 2022
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gibaros, a couple of comments for your attention.

Happy to jump on a call to discuss them with you in more detail.

Also, take note:

.circleci/config.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/server.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good @gibaros, just minor comments to address.

package.json Outdated Show resolved Hide resolved
@gibaros gibaros merged commit bc11b7c into master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants